Draft
Conversation
BREAKING CHANGE: This changes TypeScript's default behaviour away from forcing CommonsJS mode, and to support generatng ESM files in accordance with Node.js' algorithm Projects may be affected if you use `lb-tsc` and/or extend `tsconfig.*.json` from `@loopback/build`, and: - have `type: module` in `package.json`, or - have `.mts` files, or - use `import()`s (regardless if file ext. is `.ts`/`.mts`/`.cts`) see: https://www.typescriptlang.org/tsconfig/#moduleResolution see: #10744 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
feat/build-booter-esm
branch
from
48cd7db to
25846b6
Compare
BREAKING CHANGE: `loadClassesFromFiles` now returns a `Promise` see: #10744 Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
force-pushed
the
feat/build-booter-esm
branch
from
25846b6 to
9b7acd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for ESModules in
@loopback/buildand@loopback/boot.Breaking changes:
@loopback/buildtsconfig.common.jsonis updated to support hybrid CommonJS+ESModule packages. This prevents TypeScript from rewriting dynamicimport()s intorequire()s, which is needed by@loopback/boot.@loopback/bootloadClassesFromFilesnow returns aPromisePart of: #10744
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈